Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by test webhooks #3756

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

nathan818fr
Copy link
Contributor

n8n crashes when a test webhook receives two requests at exactly the same time.

/usr/local/lib/node_modules/n8n/dist/src/TestWebhooks.js:62
            clearTimeout(this.testWebhookData[webhookKey].timeout);
                                                          ^

TypeError: Cannot read properties of undefined (reading 'timeout')
    at /usr/local/lib/node_modules/n8n/dist/src/TestWebhooks.js:62:59

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2022

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Jul 22, 2022
@janober janober merged commit 8fe71db into n8n-io:master Aug 10, 2022
@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 10, 2022
@janober
Copy link
Member

janober commented Aug 10, 2022

Thanks a lot for fixing this @nathan818fr ! Got merged.

@janober
Copy link
Member

janober commented Aug 10, 2022

Got released with n8n@0.190.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants