Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HTTP Request Node): Redesign and add the ability to import cURL commands #3860

Merged
merged 65 commits into from
Sep 29, 2022
Merged

feat(HTTP Request Node): Redesign and add the ability to import cURL commands #3860

merged 65 commits into from
Sep 29, 2022

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Aug 9, 2022 •
edited
Loading

@RicardoE105 RicardoE105 changed the title ⚡ Initial commit HTTP Request V2 Aug 9, 2022
@RicardoE105 RicardoE105 marked this pull request as draft August 9, 2022 23:55
@RicardoE105 RicardoE105 changed the title HTTP Request V2 HTTP Request V2 - N8N-4311 Aug 9, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/new Creation of an entirely new node ui Enhancement in /editor-ui or /design-system labels Aug 10, 2022
@RicardoE105 RicardoE105 force-pushed the feature/http-node-redesign branch from d5bd912 to 9bf46e6 Compare August 19, 2022 15:01
@RicardoE105 RicardoE105 force-pushed the feature/http-node-redesign branch from 48a970c to 70f2aa9 Compare September 11, 2022 22:53
@RicardoE105 RicardoE105 marked this pull request as ready for review September 11, 2022 23:01
RicardoE105 and others added 20 commits September 26, 2022 17:18
@RicardoE105
Merge branch 'master' into feature/http-node-redesign
a9a23ff
@RicardoE105
⚡ update package-lock.json
2da5569
@RicardoE105
⚡ Fix linting issues
618fa34
@RicardoE105
Fix issue with css reference in ImportParameter component
215d156
@RicardoE105
⚡ Small improvements
50da7f4
@RicardoE105
⚡ Rename redirects to redirect
6c4a35a
@RicardoE105
⚡ Allow to set multiple parameters on valueChanged
da95a23
@RicardoE105
👕 Fix linting issue
45768ec
@RicardoE105
🐛 Add mistakenly removed openExistingCredentials
886afea
@RicardoE105
⚡ Improve curl regex
aa2f886
@RicardoE105
⚡ Keep headers as defined in the cURL command
a42423c
@RicardoE105
⚡ Account for all protocols supported by cURL
767cdbe
@RicardoE105
⚡ Add tests
68c031e
@RicardoE105
🔥 Remove unnecessary lines
569fac9
@RicardoE105
⚡ Add more testing
c7b0ba6
@RicardoE105
⚡ Add noDataExpression to dependent fields
69d03e0
@RicardoE105
🐛 Fix bug not handling multipart-form data correctly
554d85e
@RicardoE105
⚡ Change error messages
59c8465
@RicardoE105
🐛 Fix response format string for empty values
ce39e0e
@RicardoE105
Fix typo
f28f09f
MiloradFilipovic
MiloradFilipovic approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the front-end part. LGTM.

@RicardoE105 RicardoE105 merged commit f37d6ba into master Sep 29, 2022
@RicardoE105 RicardoE105 deleted the feature/http-node-redesign branch September 29, 2022 21:28
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 29, 2022
@janober
Copy link
Member

janober commented Sep 30, 2022

Got released with n8n@0.196.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 30, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@RicardoE105
feat(HTTP Request Node): Redesign and add the ability to import cURL …
a6a6ebe 
…commands (n8n-io#3860)

* ⚡ Initial commit

* 👕 Fix linting issue

* ⚡ Add import button

* ⚡ Remove ligh versioning

* ⚡ Improvements

* ⚡ Improvements

* 🔥 Remove HttpRequest2 file used for testing

* 🐛 Fix building issue

* ⚡ Small improvement

* 👕 Fix linting issue

* 🔥 Remove HttpRequest2 from loader

* ⚡ Update package-lock.json

* ⚡ Improvements

* ⚡ Small change

* 🐛 Fix issue retrieving splitIntoItems

* 🐛 Fix issue retrieving neverError parameter

* 🐛 Fix issue with displayOptions

* ⚡ Improvements

* ⚡ Improvements

* ⚡ Improvements

* ⚡ Improvements

* ⚡ Move cURL section to its own component

* ⚡ Improvements

* ⚡ Improvements

* ⚡ Add fix for  batching in all versions

* ⚡ Add notice to cURL modal

* 🔥 Remove comments

* ⚡ Improvements

* ⚡ Type curl-to-json endpoint

* ⚡ Fix typo

* 🔥 Remove console.logs

* ⚡ Fix typo in curl-to-json endpoint

* ⚡ Improvements

* ⚡ Improvements

* ⚡ Update package-lock.json

* ⚡ Rename import modal constant

* ⚡ Add return types to methods

* ⚡ Add CSS modules to ImportParameter component

* ⚡ Rename ImportParameter component to use kebab-case

* ⚡ Improvements

* ⚡ update package-lock.json

* ⚡ Fix linting issues

* Fix issue with css reference in ImportParameter component

* ⚡ Small improvements

* ⚡ Rename redirects to redirect

* ⚡ Allow to set multiple parameters on valueChanged

* 👕 Fix linting issue

* 🐛 Add mistakenly removed openExistingCredentials

* ⚡ Improve curl regex

* ⚡ Keep  headers as defined in the cURL command

* ⚡ Account for all protocols supported by cURL

* ⚡ Add tests

* 🔥 Remove unnecessary lines

* ⚡ Add more testing

* ⚡ Add noDataExpression to dependent fields

* 🐛 Fix bug not handling multipart-form data correctly

* ⚡ Change error messages

* 🐛 Fix response format string for empty values

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/new Creation of an entirely new node ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @MiloradFilipovic