Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign parent workflow ID to subworkflows from generic JSON #3867

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Assign parent workflow ID to subworkflows from generic JSON #3867

merged 1 commit into from
Aug 12, 2022

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Aug 11, 2022

This PR changes some important behaviors when running sub-workflows via Execute Workflow node with arbitrary JSON.

  • Assign parent workflow ID to sub-workflow so it is displayed under the Executions list
  • Use the same settings as the parent so persistence configurations are followed
  • (Code refactor: ) changed the executeWorkflow function's optional arguments to an object

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 11, 2022
@janober janober closed this Aug 12, 2022
@janober janober reopened this Aug 12, 2022
@janober janober merged commit f782bcd into master Aug 12, 2022
@janober janober deleted the n8n-4229-execute-workflow-with-source-=-parameter branch August 12, 2022 12:31
@janober
Copy link
Member

janober commented Aug 12, 2022

Thanks a lot for fixing this. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 12, 2022
@janober
Copy link
Member

janober commented Aug 17, 2022

Got released with n8n@0.191.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krynble @janober