Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code health #3960

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Improve code health #3960

merged 2 commits into from
Sep 2, 2022

Conversation

delasy
Copy link
Contributor

@delasy delasy commented Aug 26, 2022

Hey 👋 !

Hope you are having a good day! I'm active user of n8n, on daily basis, I deal with n8n core code and pretty often see some typos in code.
You should know that I get super angry when I see such things in my team's code (I'm a perfectionist in my heart 😄). So I thought: "n8n helps me every day, and I should do the same and help with what I can!"

Thank you for your time!

Fix TS typos in local variables
Fix CSS typos in local styles
Fix typos in comments
Fix typos in strings
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Aug 26, 2022
@netroy netroy self-requested a review September 2, 2022 13:58
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been quite a chore. Thanks a lot for doing this ❤️ .

@netroy netroy merged commit 49c85a1 into n8n-io:master Sep 2, 2022
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 2, 2022
@janober
Copy link
Member

janober commented Sep 6, 2022

Got released with n8n@0.193.4

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 6, 2022
ivov pushed a commit that referenced this pull request Sep 6, 2022
* Improve code health
Fix TS typos in local variables
Fix CSS typos in local styles
Fix typos in comments
Fix typos in strings

* Fix order of n8n setup sections in CONTRIBUTING.md
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* Improve code health
Fix TS typos in local variables
Fix CSS typos in local styles
Fix typos in comments
Fix typos in strings

* Fix order of n8n setup sections in CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants