Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials #4043

Merged

Conversation

cstuncsik
Copy link
Contributor

image (3)

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2022

CLA assistant check
All committers have signed the CLA.

@cstuncsik cstuncsik requested a review from mutdmour September 6, 2022 20:09
@cstuncsik cstuncsik changed the title [N8N-4518] Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials fix(editor): [N8N-4518] Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials Sep 6, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 6, 2022
@cstuncsik cstuncsik changed the title fix(editor): [N8N-4518] Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials fix(editor): Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials Sep 7, 2022
@cstuncsik cstuncsik merged commit 0acac35 into master Sep 7, 2022
@cstuncsik cstuncsik deleted the n8n-4518-wrong-title-after-copy-oauth-redirect-url branch September 7, 2022 07:52
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 7, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with n8n@0.194.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…t Url credentials (n8n-io#4043)

fix(editor): use toast title only when oauth redirect url copied to clipboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants