Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Kafka Node): add key option for messages #4210

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

jbacklund
Copy link
Contributor

Add key to message.
Add key to properties.

https://community.n8n.io/t/add-key-to-kafka-message/18134

Add key to message.
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

@jbacklund jbacklund changed the title Allow adding key to message. Kafka: Allow adding key to message. Sep 27, 2022
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Sep 27, 2022
@jbacklund jbacklund changed the title Kafka: Allow adding key to message. Kafka Allow adding key to message. Sep 29, 2022
@nanderss
Copy link

Could this be merged? We really need this fix.

@Joffcom Joffcom changed the title Kafka Allow adding key to message. feat(Kafka Node): add key option for messages Oct 12, 2022
Joffcom
Joffcom previously approved these changes Oct 12, 2022
@Joffcom
Copy link
Member

Joffcom commented Oct 12, 2022

Hey @jbacklund,

Thanks for the PR, I have just given it a test and it works as expected 👍🏻

@Joffcom
Copy link
Member

Joffcom commented Oct 12, 2022

@jbacklund merging now, Thanks again for this one 👍🏻

@Joffcom Joffcom merged commit 1811c54 into n8n-io:master Oct 12, 2022
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 12, 2022
@janober
Copy link
Member

janober commented Oct 14, 2022

Got released with n8n@0.198.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 14, 2022
@sdahlbac
Copy link

@janober yay! I was however surprised to not see author credited under https://docs.n8n.io/reference/release-notes/#n8n01980 Contributors

@janober
Copy link
Member

janober commented Oct 18, 2022

Very sorry for that, something must have gone wrong. I did already communicate it internally and will be fixed soon.

valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants