Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Node): add the Scheduler Node #4223

Merged
merged 18 commits into from
Oct 18, 2022
Merged

Conversation

agobrech
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 28, 2022

N8N-4454

@agobrech agobrech changed the title feat Node: add the Scheduler Node feat(Node): add the Scheduler Node Sep 28, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Sep 28, 2022
@luizeof
Copy link
Contributor

luizeof commented Sep 28, 2022

@agobrech will this replace the Cron node?

@agobrech
Copy link
Contributor Author

@agobrech will this replace the Cron node?

Hi @luizeof, the scheduler is a combination of the Cron node and the Interval Node with some added features. Workflows that still have the Cron node or the Interval node will still work. You won't be able to find the old Cron node and the old Interval node in the node menu.

krynble
krynble previously approved these changes Sep 30, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added 2 minor comments about it, maybe we should change those. Other than this it's all good.

@netroy
Copy link
Member

netroy commented Oct 12, 2022

We unified Cron expression generation a while ago. This change kinda reverts that by creating 2 different implementations again.
can we perhaps we merge the two implementations to avoid inconsistent behaviors?

@agobrech agobrech merged commit 128c3b8 into master Oct 18, 2022
@agobrech agobrech deleted the n8n-4454-create-schedule-trigger branch October 18, 2022 11:59
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 18, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with n8n@0.199.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* ✨ Create Schedule node with MVP structure

* ✨ Add 24 increments for hours picker

* 🚨  Lintfix

* Add timestamp, add hour minute and cron expression

* Fix bug where there was one extra interval object

* Fix default value from fixedCollection

* 🐛 UI fixes

* 🎨 Changed logic to reflect UI fixes

* Fix auto intitialising

* Deprecated interval and cron in favor of schedule node

* 🐛 Ui fixes

* 🐛 Fix issue with week intervals

* 🚨 Lint fixes

* change order of days in the week to chronological order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants