Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Email Trigger (IMAP) Node): improve connection handling and credentials #4393

Merged
merged 4 commits into from
Oct 24, 2022
Merged

fix(Email Trigger (IMAP) Node): improve connection handling and credentials #4393

merged 4 commits into from
Oct 24, 2022

Conversation

flipswitchingmonkey
Copy link
Contributor

  • The allowUnauthorizedCerts option is being moved from the node options to Imap.credentials.ts, so it is available during credentials testing
  • Force Reconnect option label changed to make it more obvious it is minutes, not seconds
  • Losing the IMAP connection whilst workflow is active will now emitError and attempt re-activation of workflow and thus reconnecting
  • Forced reconnection will be disabled during reactivation, but will be enabled again once workflow is running again
  • Retrieved messages are only marked as seen once their processing has finished
  • added Versioning to the node, new version being V2

@linear
Copy link

linear bot commented Oct 20, 2022

N8N-4959

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Oct 20, 2022
@flipswitchingmonkey flipswitchingmonkey changed the title fix(EmailReadImap): improve connection handling and credentials fix(Email Trigger (IMAP) Node): improve connection handling and credentials Oct 20, 2022
@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review October 20, 2022 15:08
@flipswitchingmonkey flipswitchingmonkey merged commit 1a37f00 into master Oct 24, 2022
@flipswitchingmonkey flipswitchingmonkey deleted the n8n-4959-imap-email-trigger-stops-capturing-new branch October 24, 2022 09:06
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 24, 2022
@janober
Copy link
Member

janober commented Oct 27, 2022

Got released with n8n@0.200.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 27, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@flipswitchingmonkey
fix(Email Trigger (IMAP) Node): improve connection handling and crede…
73d77cb 
…ntials (n8n-io#4393)

* adds EmailReadImapV2 with fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flipswitchingmonkey @CLAassistant @janober @Joffcom