Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hide credentials password values #4868

Merged
merged 5 commits into from
Dec 15, 2022
Merged

feat: Hide credentials password values #4868

merged 5 commits into from
Dec 15, 2022

Conversation

valya
Copy link
Contributor

@valya valya commented Dec 8, 2022 •
edited by janober
Loading

@valya valya changed the title feat: hide credentials password values feat: Hide credentials password values Dec 8, 2022
@valya
fix: redacting credentials without a valid type
315bf0d 
This only seems to be a thing in testing?
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 8, 2022
freyamade
freyamade previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me!

freyamade
freyamade approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valya valya merged commit fe0f982 into master Dec 15, 2022
@valya valya deleted the pay-7-hide-the-contents-of-password-fields-in branch December 15, 2022 13:31
MiloradFilipovic added a commit that referenced this pull request Dec 15, 2022
@MiloradFilipovic
Merge branch 'master' into N8N-5492-e2e-canvas-actions
b42e180 
* master:
  feat: Hide credentials password values (#4868)
  refactor: Phase out TSLint in `editor-ui` (no-changelog) (#4935)
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 15, 2022
@janober
Copy link
Member

janober commented Dec 16, 2022

Got released with n8n@0.208.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freyamade freyamade freyamade approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valya @janober @freyamade