Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Allow for hiding usage page via environment #4899

Merged
merged 1 commit into from
Dec 13, 2022
Merged

feat(core): Allow for hiding usage page via environment #4899

merged 1 commit into from
Dec 13, 2022

Conversation

freyamade
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 12, 2022
krynble
krynble approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the hideUsagePage inside the enterprise block, sibling to the features attribute, WDYT?

@freyamade
Copy link
Contributor Author

freyamade commented Dec 13, 2022 •
edited
Loading

I guess it might be an enterprise feature? All I know is it's being hidden on cloud 🤔

Happy to move it if that would be preferred though!

@krynble
Copy link
Contributor

krynble commented Dec 13, 2022

I think this is fine actually, you can merge it as is. We can change later if needed.

@freyamade freyamade merged commit 0f40ca3 into master Dec 13, 2022
@freyamade freyamade deleted the pay-18-allow-hiding-of-usage-page-via branch December 13, 2022 13:59
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 13, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 13, 2022
@MiloradFilipovic
Merge branch 'master' into ADO-32-e2e-undo
2797de1 
* master:
  feat(core): Allow for hiding usage page via environment (#4899)
@janober
Copy link
Member

janober commented Dec 16, 2022

Got released with n8n@0.208.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freyamade @krynble @janober