perf: Lazy-load public-api dependencies to reduce baseline memory usage #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
netroy
commented
Dec 28, 2022
| @@ -19,6 +19,9 @@ if (inE2ETests) { | |||
| EXTERNAL_FRONTEND_HOOKS_URLS: '', | |||
| N8N_PERSONALIZATION_ENABLED: 'false', | |||
| }; | |||
| } | |||
| if (inTest) { | |||
| process.env.N8N_PUBLIC_API_DISABLED = 'true'; | |||
There was a problem hiding this comment.
This helps with cutting down the heap usage in tests by about 15%, which in turn helps avoid OOM issues.
n8n-assistant
bot
added
core
netroy
commented
Dec 29, 2022
netroy
force-pushed
the
lazy-load-dependencies
branch
from
40cd619 to
98daae4
Compare
netroy
force-pushed
the
lazy-load-dependencies
branch
from
98daae4 to
d031a96
Compare
netroy
changed the title
netroy
changed the title
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the startup memory spike from 200MB to 150MB, and the baseline memory usage from 110MB to 99MB
PS: This is with public-api enabled, but swagger-ui disabled. With swagger-ui (which is the default), there is no reduction in the baseline memory usage, but the initial memory spike is still flattened to 160-170MB.