feat(editor): Add SSO fakedoor feature #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexgrozav
commented
Jan 3, 2023
•
alexgrozav
commented
alexgrozav
changed the title
krynble
previously approved these changes
Jan 3, 2023
There was a problem hiding this comment.
LGTM!
Considerations:
- visible to all users (even non-owners)
- Text is slightly different than the one for logging on the line that says
We’re working on this (as a paid feature). The logging version mentions the feature name as well (not a big deal, just pointing a minor divergence in phrasing)
n8n-assistant
bot
added
n8n team
krynble
approved these changes
Jan 3, 2023
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.