Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix node authentication options ordering and hiding options based on node version #5268

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

No description provided.

@MiloradFilipovic MiloradFilipovic changed the title fix (editor): Fix node authentication options ordering and hiding options based on node version fix(editor): Fix node authentication options ordering and hiding options based on node version Jan 27, 2023
@MiloradFilipovic MiloradFilipovic self-assigned this Jan 27, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 27, 2023
OlegIvaniv
OlegIvaniv previously approved these changes Jan 27, 2023
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌! Left just one small nitpick comment, but feel free to merge without

packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
@MiloradFilipovic MiloradFilipovic merged commit 7d74181 into master Jan 27, 2023
@MiloradFilipovic MiloradFilipovic deleted the ADO-260-node-auth-options-fixes branch January 27, 2023 12:20
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 27, 2023
@janober
Copy link
Member

janober commented Jan 27, 2023

Got released with n8n@0.213.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants