Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Change executions title to match menu #5349

Merged
merged 3 commits into from
Feb 3, 2023
Merged

fix(editor): Change executions title to match menu #5349

merged 3 commits into from
Feb 3, 2023

Conversation

cstuncsik
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@cstuncsik cstuncsik changed the title Pay 124 change executions title to match menu fix(editor): Change executions title to match menu Feb 3, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 3, 2023
krynble
krynble approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One minor nuisance is that we say "All workflows" even if the user filter by Failed executions of workflow XYZ, making it a bit misleading.

@cstuncsik
Copy link
Contributor Author

@krynble agree

@cstuncsik cstuncsik merged commit 338b354 into master Feb 3, 2023
@cstuncsik cstuncsik deleted the pay-124-change-executions-title-to-match-menu branch February 3, 2023 13:00
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 3, 2023
@janober
Copy link
Member

janober commented Feb 3, 2023

Got released with n8n@0.214.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @krynble