Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon broken for custom node using npm scoped name #5585

Closed
David-Hari opened this issue Mar 1, 2023 · 3 comments · Fixed by #5626
Closed

Icon broken for custom node using npm scoped name #5585

David-Hari opened this issue Mar 1, 2023 · 3 comments · Fixed by #5626
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@David-Hari
Copy link

Describe the bug
I have a node that is in an npm package. It is using npm scoped name like "@companyName/n8n-nodes-ourNode".

Since updating to 0.217.2 the icon is no longer showing.
/icons/@companyName/n8n-nodes-ourNode/dist/icon.svg gives a 404

Expected behavior
The URL should return the icon and it should be visible in the UI

Environment (please complete the following information):

  • OS: Windows 10
  • n8n Version: 0.217.2
  • Node.js Version: 16.17.0
  • Database system: SQLite

Additional context
This seems to have been broken by #5481, which uses a regex in the /icons URL served. That regex matches ":packageName" to only the scope part of the name (e.g. "@companyname") instead of the full name.

@Joffcom
Copy link
Member

Joffcom commented Mar 1, 2023

Hey @David-Hari,

Thanks for reporting this one, I have created N8N-6217 as our internal ticket to get this resolved.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Mar 1, 2023
@Joffcom Joffcom added the Upcoming Release Will be part of the upcoming release label Mar 6, 2023
@Joffcom
Copy link
Member

Joffcom commented Mar 6, 2023

Hey @David-Hari,

Just to let you know this has been fixed and will be available from the next release, There will be another notification here once the release is available.

@janober
Copy link
Member

janober commented Mar 10, 2023

Fix got released with n8n@0.219.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants