-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Fix autocomplete for complex expresions #5695
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5695 +/- ##
==========================================
+ Coverage 13.03% 13.07% +0.04%
==========================================
Files 2454 2462 +8
Lines 112599 112715 +116
Branches 17491 17502 +11
==========================================
+ Hits 14679 14740 +61
- Misses 97420 97475 +55
Partials 500 500
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might need to tighten up extractSubExpression
to handle some of the edge cases. I left a comment in Linear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now! Nice job 👏
Got released with |
* ✨ Fixing autocomplete for expressions as function arguments * ✅ Added more autocomplete tests * ⚡ Improving autocomplete for complex expressions * ⚡ Handling complex operation expressions in autocomplete
Github issue / Community forum post (link here to close automatically):