Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix autocomplete for complex expresions #5695

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 15, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.04 🎉

Comparison is base (39c871d) 13.03% compared to head (4b575a0) 13.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5695      +/-   ##
==========================================
+ Coverage   13.03%   13.07%   +0.04%     
==========================================
  Files        2454     2462       +8     
  Lines      112599   112715     +116     
  Branches    17491    17502      +11     
==========================================
+ Hits        14679    14740      +61     
- Misses      97420    97475      +55     
  Partials      500      500              
Impacted Files Coverage Δ
packages/editor-ui/src/stores/nodeCreator.ts 16.12% <0.00%> (-0.09%) ⬇️
.../nodes-base/nodes/Metabase/QuestionsDescription.ts 0.00% <0.00%> (ø)
...tor-ui/src/plugins/codemirror/completions/utils.ts 86.39% <96.66%> (+1.64%) ⬆️
...s-base/nodes/SplitInBatches/SplitInBatches.node.ts 84.61% <100.00%> (+8.14%) ⬆️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need to tighten up extractSubExpression to handle some of the edge cases. I left a comment in Linear

Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now! Nice job 👏

@netroy netroy merged commit 11bf260 into master Mar 16, 2023
@netroy netroy deleted the ADO-417-autocomplete-complex-expressions branch March 16, 2023 11:13
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* ✨ Fixing autocomplete for expressions as function arguments

* ✅ Added more autocomplete tests

* ⚡ Improving autocomplete for complex expressions

* ⚡ Handling complex operation expressions in autocomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants