Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Properly handle mapping of dragged expression if it contains hyphen #5703

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Mar 16, 2023

This PR addresses an issue with the generatePath method in handling path elements containing hyphens. It also includes additional unit tests to ensure the correct behavior of getMappedExpression method.

  • Updated the generatePath method to handle path elements containing hyphens properly by wrapping them in double quotes.
  • Added new unit tests to cover different cases for the getMappedExpression method.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (541850f) 13.05% compared to head (4202e8a) 13.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   13.05%   13.08%   +0.02%     
==========================================
  Files        2462     2462              
  Lines      112686   112715      +29     
  Branches    17498    17504       +6     
==========================================
+ Hits        14715    14746      +31     
+ Misses      97471    97469       -2     
  Partials      500      500              
Impacted Files Coverage Δ
packages/editor-ui/src/utils/mappingUtils.ts 97.10% <100.00%> (+8.69%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 7025efe into master Mar 16, 2023
@netroy netroy deleted the ado-422-dragging-items-to-fields-breaks-if-there branch March 16, 2023 13:10
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants