Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Disable tooltip for display modes that don't support mapping #5715

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(editor): Disable tooltip for display modes that don't support mapping #5715

merged 1 commit into from
Mar 17, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

No description provided.

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 17, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 17, 2023
@MiloradFilipovic MiloradFilipovic merged commit fb8755e into master Mar 17, 2023
@MiloradFilipovic MiloradFilipovic deleted the ADO-198-disable-mapping-tooltip-for-binary-input branch March 17, 2023 12:24
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 17, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@MiloradFilipovic @sunilrr
fix(editor): Disable tooltip for display modes that don't support map…
c5f0529 
…ping (n8n-io#5715)

fix(editor): Disable mapping tooltip for display modes that don't support mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @OlegIvaniv