Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Extract From File Node): Make binary data work with any backend #8647

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 15, 2024

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 15, 2024
Copy link

cypress bot commented Feb 15, 2024

1 flaky test on run #4127 ↗︎

0 336 12 0 Flakiness 1

Details:

🌳 1.29.1-pr 🖥️ browsers:node18.12.0-chrome107 🤖 aditya 🗃️ e2e/*
Project: n8n Commit: 61a198cab3
Status: Passed Duration: 03:37 💡
Started: Feb 16, 2024 9:00 AM Ended: Feb 16, 2024 9:04 AM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8647 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@MiloradFilipovic MiloradFilipovic requested review from MiloradFilipovic and removed request for MiloradFilipovic February 16, 2024 08:25
@netroy netroy merged commit d33d953 into master Feb 16, 2024
25 of 28 checks passed
@netroy netroy deleted the n8n-7200 branch February 16, 2024 08:38
netroy added a commit that referenced this pull request Feb 16, 2024
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
@janober
Copy link
Member

janober commented Feb 16, 2024

Got released with n8n@1.29.1

@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants