fix(core): Apply correct hostname to redirected requests #8674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
requested changes
Feb 20, 2024
netroy
approved these changes
Feb 20, 2024
2 flaky tests on run #4150 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8674 ↗︎
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1149-recent-change-to-host-header-breaks-redirect-downloads
branch
cstuncsik
pushed a commit
that referenced
this pull request
Feb 21, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Broken in #8562
servernameset on the httpsAgent was also being used for redirected requests. When redirected to another domain this breaks. This PR updates theAgent.servernamewhen redirected.workflow test added here: n8n-io/test-workflows#263
Related tickets and issues
https://linear.app/n8n/issue/NODE-1149/recent-change-to-host-header-breaks-redirect-downloads
fixes #8668
https://community.n8n.io/t/ignore-ssl-setting-isnt-working-error-ssl-issue-consider-using-the-ignore-ssl-issues-option/40492
Review / Merge checklist
(no-changelog)otherwise. (conventions)