Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .toUpperCase from getter within RouteModel and rename getter #188

Closed
3 tasks done
n8rzz opened this issue Dec 11, 2016 · 0 comments
Closed
3 tasks done

Remove .toUpperCase from getter within RouteModel and rename getter #188

n8rzz opened this issue Dec 11, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@n8rzz
Copy link
Owner

n8rzz commented Dec 11, 2016

RouteModel#getRouteString

  • rename to something without the word string in it, routeStr or formattedRoute
  • update usages across app
  • remove the inline .toUpperCase() from the getter and move that to where those properties are actually set within the _init() method.
@n8rzz n8rzz added the refactor label Dec 11, 2016
@n8rzz n8rzz added this to the v3.2.0 milestone Dec 12, 2016
@n8rzz n8rzz added WIP and removed WIP labels Dec 12, 2016
@n8rzz n8rzz closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants