Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrivals' landings cause "waiting" departures to be deleted #241

Closed
erikquinn opened this issue Dec 23, 2016 · 3 comments
Closed

Arrivals' landings cause "waiting" departures to be deleted #241

erikquinn opened this issue Dec 23, 2016 · 3 comments
Assignees
@erikquinn
Labels
bug Pull Request
Milestone
v3.2.1

Comments

@erikquinn
Copy link
Collaborator

erikquinn commented Dec 23, 2016 •
edited
Loading

See zlsa#770.
@erikquinn erikquinn added the bug label Dec 23, 2016
@erikquinn erikquinn added this to the v3.2.1 milestone Dec 23, 2016
@erikquinn
Copy link
Collaborator Author

For some reason, when the aircraft land and should be removed, the call of this.aircraft_remove(aircraft) in AircraftController.js:224 also ends up partially removing the other aircraft...

@erikquinn
Copy link
Collaborator Author

erikquinn commented Dec 31, 2016 •
edited
Loading

AirportController.removeAircraftFromAllRunwayQueues() is where this is breaking. For some reason that isn't obvious at all by looking at it, the aircraft that's next in the queue is getting messed up when we try to remove the arrival from the queue (which is kinda unnecessary anyway).

@erikquinn erikquinn mentioned this issue Dec 31, 2016
Merged
@erikquinn erikquinn self-assigned this Dec 31, 2016
@erikquinn
Copy link
Collaborator Author

Fixed via #250.

@erikquinn erikquinn mentioned this issue Jan 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikquinn erikquinn

Labels
bug Pull Request
Projects
None yet
Milestone
v3.2.1
Development

No branches or pull requests
1 participant
@erikquinn