Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AreaModel to AirspaceModel #36

Closed
n8rzz opened this issue Oct 14, 2016 · 4 comments
Closed

Rename AreaModel to AirspaceModel #36

n8rzz opened this issue Oct 14, 2016 · 4 comments
Assignees
Milestone

Comments

@n8rzz
Copy link
Owner

n8rzz commented Oct 14, 2016

No description provided.

@n8rzz n8rzz added this to the v3.0.x milestone Oct 14, 2016
@n8rzz
Copy link
Owner Author

n8rzz commented Oct 14, 2016

It looks like most of the logic needed here is already covered with the AreaModel class.

@n8rzz n8rzz self-assigned this Oct 15, 2016
@n8rzz n8rzz mentioned this issue Oct 15, 2016
@n8rzz n8rzz added the WIP label Oct 15, 2016
@erikquinn
Copy link
Collaborator

It looks like most of the logic needed here is already covered with the AreaModel class.

Correct, that was what it was made for actually.

@n8rzz
Copy link
Owner Author

n8rzz commented Oct 18, 2016

yeah, I should have looked into that a little more before I started coding a new class. 🤕 I had one, then I started implementing the AreaClass within the new one and had the "I'm an idiot!" moment. ugh, I should know better.

I ended up just re-working the existing class and adding tests. I will probably just rename it to AirspaceModel and move it to be within the airport directory so its concerns are a little clearer.

You can check the MR to see what I ended up with. This will be for develop though, so v3.0.x.

@n8rzz n8rzz changed the title Add Airspace class Update AreaModel name to AirspaceModel Oct 21, 2016
@n8rzz n8rzz changed the title Update AreaModel name to AirspaceModel Rename AreaModel name to AirspaceModel Oct 21, 2016
@n8rzz n8rzz changed the title Rename AreaModel name to AirspaceModel Rename AreaMode to AirspaceModel Oct 21, 2016
@n8rzz
Copy link
Owner Author

n8rzz commented Oct 21, 2016

  • rename AreaModel to AirspaceModel
  • add tests
  • update implementations

@n8rzz n8rzz changed the title Rename AreaMode to AirspaceModel Rename AreaModel to AirspaceModel Oct 24, 2016
@n8rzz n8rzz removed the WIP label Oct 30, 2016
@n8rzz n8rzz closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants