Wrap values in travis env (#426)

* Wrap values in travis env * Inline CronService
phpvms · Oct 30, 2019 · 70d43e6 · 70d43e6
1 parent a457707
commit 70d43e6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 44 deletions.
diff --git a/.travis/env.travis b/.travis/env.travis
diff --git a/.travis/env.travis.php b/.travis/env.travis.php
@@ -2,29 +2,28 @@
 exit();
 ?>
 
-APP_ENV=dev
-APP_KEY=base64:zdgcDqu9PM8uGWCtMxd74ZqdGJIrnw812oRMmwDF6KY=
-APP_URL=http://localhost
-APP_SKIN=default
-APP_DEBUG=true
-APP_LOCALE=en
+APP_ENV="dev"
+APP_KEY="base64:zdgcDqu9PM8uGWCtMxd74ZqdGJIrnw812oRMmwDF6KY="
+APP_URL="http://localhost"
+APP_SKIN="default"
+APP_DEBUG="true"
+APP_LOCALE="en"
 
-PHPVMS_INSTALLED=true
-VACENTRAL_API_KEY=
+PHPVMS_INSTALLED="true"
 
-APP_LOG=daily
-APP_LOG_LEVEL=debug
-APP_LOG_MAX_FILES=3
+APP_LOG="daily"
+APP_LOG_LEVEL="debug"
+APP_LOG_MAX_FILES="3"
 
-DB_CONNECTION=mysql
-DB_HOST=127.0.0.1
-DB_PORT=3306
-DB_DATABASE=phpvms
-DB_USERNAME=root
+DB_CONNECTION="mysql"
+DB_HOST="127.0.0.1"
+DB_PORT="3306"
+DB_DATABASE="phpvms"
+DB_USERNAME="root"
 DB_PASSWORD=
 
-CACHE_DRIVER=file
+CACHE_DRIVER="file"
 CACHE_PREFIX=
 
-SESSION_DRIVER=file
-QUEUE_DRIVER=database
+SESSION_DRIVER="file"
+QUEUE_DRIVER="database"
diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php
@@ -8,20 +8,10 @@
 use App\Console\Cron\Weekly;
 use App\Services\CronService;
 use Illuminate\Console\Scheduling\Schedule;
-use Illuminate\Contracts\Events\Dispatcher;
-use Illuminate\Contracts\Foundation\Application;
 use Illuminate\Foundation\Console\Kernel as ConsoleKernel;
 
 class Kernel extends ConsoleKernel
 {
-    private $cronSvc;
-
-    public function __construct(Application $app, Dispatcher $events)
-    {
-        parent::__construct($app, $events);
-        $this->cronSvc = app(CronService::class);
-    }
-
     /**
      * Define the application's command schedule.
      *
@@ -41,7 +31,8 @@ protected function schedule(Schedule $schedule): void
         $schedule->command('backup:run')->daily()->at('02:00');
 
         // Update the last time the cron was run
-        $this->cronSvc->updateLastRunTime();
+        $cronSvc = app(CronService::class);
+        $cronSvc->updateLastRunTime();
     }
 
     /**