Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfleet and Aircraft Expenses Being Applied to Wrong Airline #1723

Closed
FatihKoz opened this issue Dec 16, 2023 · 0 comments · Fixed by #1725
Closed

Subfleet and Aircraft Expenses Being Applied to Wrong Airline #1723

FatihKoz opened this issue Dec 16, 2023 · 0 comments · Fixed by #1725

Comments

@FatihKoz
Copy link
Contributor

Subfleet and Aircraft based expenses are being applied to all airlines, even to airlines without subfleets/aircraft.

Version
7.0.0-dev+231215.655f15

To Reproduce
Steps to reproduce the behavior:

  1. Go to Admin > Fleets, pick one subfleet and click edit
  2. Add some daily expenses to the subfleet
  3. Either wait for daily cron to run at midnight or force run it
  4. Check your cron log, you will see that the expense is applied to other airlines and subfleets too (!)
  5. Also check your finances, or better transactions, you will see that the expense is applied at all assets (!)

Expected behavior
Daily / Monthly expenses should be applied to relevant subfleets / aircraft, not to all.

Additional context
Looks like there are logical problems while picking up proper objects.

image

image

image

[2023-12-16 16:02:49] production.INFO: Nightly: Applying daily expenses  
[2023-12-16 16:02:49] production.INFO: Charging to DSH  
[2023-12-16 16:02:49] production.INFO: Charging to DSC  
[2023-12-16 16:02:49] production.INFO: Charging to DSH  
[2023-12-16 16:02:49] production.INFO: Expense memo: "Subfleet Expense: Daily Check"; group: "Subfleet: Daily Check" charged!  
[2023-12-16 16:02:49] production.INFO: Charging to DSC  
[2023-12-16 16:02:49] production.INFO: Expense memo: "Subfleet Expense: Daily Check"; group: "Subfleet: Daily Check" charged!  
[2023-12-16 16:02:49] production.INFO: Nightly: Recalculating balances  
[2023-12-16 16:02:59] production.INFO: Monthly: Applying monthly expenses  
[2023-12-16 16:02:59] production.INFO: Charging to DSH  
[2023-12-16 16:02:59] production.INFO: Charging to DSC  
[2023-12-16 16:02:59] production.INFO: Charging to DSH  
[2023-12-16 16:02:59] production.INFO: Expense memo: "Subfleet Expense: Leasing Payments"; group: "Subfleet: Leasing Payments" charged!  
[2023-12-16 16:02:59] production.INFO: Charging to DSC  
[2023-12-16 16:02:59] production.INFO: Expense memo: "Subfleet Expense: Leasing Payments"; group: "Subfleet: Leasing Payments" charged!  
[2023-12-16 16:02:59] production.INFO: Charging to DSH  
[2023-12-16 16:02:59] production.INFO: Expense memo: "Aircraft Expense: Aircraft Leasing Expenses (TC-DSP)"; group: "Aircraft: Aircraft Leasing Expenses (TC-DSP-TC-DSP)" charged!  
[2023-12-16 16:02:59] production.INFO: Charging to DSC  
[2023-12-16 16:02:59] production.INFO: Expense memo: "Aircraft Expense: Aircraft Leasing Expenses (TC-DSP)"; group: "Aircraft: Aircraft Leasing Expenses (TC-DSP-TC-DSP)" charged!  

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant