-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker for production #1834
base: dev
Are you sure you want to change the base?
Conversation
ports: | ||
- '${FORWARD_DB_PORT:-3306}:3306' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to expose ports if the DB will only be used for the app.
Hi @Lapotor, |
Should be approved, it is important for getting a development environment as easy as possible. |
Looks like a few things still need to be addressed |
6b1e0f7
to
45da5a1
Compare
268ee9e
to
8ecdcf8
Compare
Alright, so I've been running a Docker stack on my server for a while, but it has some drawbacks, and I'm not skilled enough with Docker to fix everything. I need your opinions. For me, there should be 4 containers:
A few things I think need to be revisited:
|
Closes #1815
STILL WIP