Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Create Docker Image for "production" use #1815

Open
Lapotor opened this issue May 29, 2024 · 3 comments · May be fixed by #1834
Open

Feature Request: Create Docker Image for "production" use #1815

Lapotor opened this issue May 29, 2024 · 3 comments · May be fixed by #1834

Comments

@Lapotor
Copy link

Lapotor commented May 29, 2024

Summary

This feature request proposes the creation and provision of an Docker image for phpvms. The introduction of an Docker image will streamline the setup process for users, offering a more convenient and standardized environment for running the software, alongside the existing development setup facilitated by Laravel Sail.

Context

Currently, phpvms supports two primary methods of setup:

  1. Development environment using Laravel Sail.
  2. Bare-metal setup as described in the project documentation.

While these methods are functional, the absence of an Docker image presents a barrier for users who prefer or require containerized environments for deployment and management. An Docker image would bridge this gap, enhancing the usability and adoption of phpvms.

Benefits

  • Ease of Setup: Users can quickly set up a phpvms environment without dealing with complex dependencies and configurations.
  • Consistency: The Docker image ensures a consistent environment across different machines and setups, reducing the "it works on my machine" problem.
  • Portability: Containerized environments can be easily moved across different systems, facilitating testing, development, and deployment.

Conclusion

Providing an Docker image for phpvms will significantly enhance the user experience by simplifying the setup process and providing a reliable, consistent, and portable environment for managing virtual airlines. This addition aligns with modern development and deployment practices, ensuring phpvms remains accessible and easy to use for a broader audience.

@nabeelio
Copy link
Owner

nabeelio commented May 29, 2024

Yeah, a production composer and Dockerfile is needed. I can work on this sometime based on a couple that I use.
Reference

@arthurpar06
Copy link
Contributor

Yes, that would definitely be a good idea. We might also consider FrankenPHP (https://frankenphp.dev/), which is based on Caddy and acts as a replacement for PHP-FPM. The Laravel integration seems quite simple (don't focus on the part with Laravel Octane).

@Lapotor
Copy link
Author

Lapotor commented Jun 4, 2024

Why not just use the official php-fpm or php-apache as base?

@arthurpar06 arthurpar06 linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants