Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight Importer Not Considering Days #1860

Closed
FatihKoz opened this issue Aug 6, 2024 · 0 comments · Fixed by #1861
Closed

Flight Importer Not Considering Days #1860

FatihKoz opened this issue Aug 6, 2024 · 0 comments · Fixed by #1861

Comments

@FatihKoz
Copy link
Contributor

FatihKoz commented Aug 6, 2024

While importing flights via csv, importer does not check/consider days to match current flights. Thus updating the last record always.

airline,flight_number,route_code,callsign,route_leg,dpt_airport,arr_airport,alt_airport,days,dpt_time,arr_time,level,distance,flight_time,flight_type,load_factor,load_factor_variance,pilot_pay,route,notes,start_date,end_date,active,subfleets,fares,fields,event_id,user_id
THY,48,,,,EDDF,EDDV,,5,09:05,09:55,,152.52,50,J,91,19,,,,,,1,A320,,,,
THY,48,,,,EDDF,EDDV,,6,09:00,09:50,,152.52,50,J,83,14,,,,,,1,B738,,,,
THY,48,,,,EDDF,EDDV,,7,09:10,10:00,,152.52,50,J,84,19,,,,,,1,A321,,,,

In the above example, we should have 3 different flights, on 3 different days.

We can create those flights manually and can export. Only import fails.

Version
Latest dev as of date.

To Reproduce
Steps to reproduce the behavior:

  1. Use the above csv example
  2. Import those flights
  3. Check the result
  4. See error (you will have only one flight, updated to have 3 subfleets),

Expected behavior
Flights on different days may have different times and equipment, even though they can share the same flight number they should be considered as different flights in our environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant