Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pireps page: 'Pending' doesn't show pending PIREPs #427

Closed
voipmeister opened this issue Oct 30, 2019 · 2 comments
Closed

Pireps page: 'Pending' doesn't show pending PIREPs #427

voipmeister opened this issue Oct 30, 2019 · 2 comments

Comments

@voipmeister
Copy link
Contributor

voipmeister commented Oct 30, 2019

Describe the bug
In the admin section of the site, the Pirep page doesn't filter on pending PIREPs.

Version
version 7.0.0 (build 191030.70d43e)

To Reproduce
Steps to reproduce the behavior:

  1. Make sure there is a PIREP with a status of 'Pending'
  2. Log in as admin in phpvms
  3. Click on 'Pireps'
  4. Click on 'Pending' in the top right corner.
  5. See the Pending PIREP disappear

Expected behavior
The pending PIREP should still be shown.

Screenshots
Added.

Additional context
The URL shown is https:///admin/pireps?search=status:0
I have tried with 1 and -1 as well, no change. Haven't looked at the code yet, sorry.

URL: https:///admin/pireps
Result:
Screenshot 2019-10-30 at 22 03 45

URL: https:///admin/pireps?search=status:0 (after clicking on Pending)
Result:
Screenshot 2019-10-30 at 22 10 28

@nabeelio
Copy link
Owner

nabeelio commented Nov 4, 2019

Hmm, that's strange, it seems to be showing up for me:

image

Lemme investigate the code. It uses the Repository search functionality (https://github.com/andersao/l5-repository#example-the-criteria)

@nabeelio
Copy link
Owner

Is this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants