Credits (Feature Request) #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabeelio
added a commit
that referenced
this pull request
Oct 14, 2024
|
Sorry... I read to not do it until the other ticket was closed. Whoops. Can you reopen? |
|
Technically looks like I can't re-open this anymore, but I can send it again as a different PR maybe 🐱 Will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple example about how to read
module.jsonfile and provide some credits.Most of the "Module" facade attributes are protected, thus a direct reading was required.
Should not be merged directly, this is still a maturing idea
Closes #1867 when finished 😺