Add SimBrief Rate Limiting #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code limits the number of requests to the route to 10 per minute. Once this limit is exceeded, requests are blocked, but the block only lasts for one or two minutes, so users are not locked out for several hours.
Additionally, the SimBrief code (frontend) has been updated to avoid sending more than 5 requests, with a delay of 1500ms between each request. This allows us to smooth out the requests we send afterward.
Example below:
You can see that I triggered the rate limiter, received 429 errors, then got the popup notifying me of a problem. If I regenerate about a minute later, I get a 200 status, and the generation works.