Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed git hash doesn't match latest even when they should. #55

Closed
svmnotn opened this issue Nov 13, 2017 · 8 comments
Closed

Installed git hash doesn't match latest even when they should. #55

svmnotn opened this issue Nov 13, 2017 · 8 comments

Comments

@svmnotn
Copy link

svmnotn commented Nov 13, 2017

I have installed i3status-rust from its git repo, and it hasn't had a commit in 4 days, but when I run cargo install-update -ag it tries to update it due to it listing a different hash. This has happened with other packages install through git

@svmnotn
Copy link
Author

svmnotn commented Nov 13, 2017

I suppose this should be fixed when this cargo issue is resolved

@svmnotn
Copy link
Author

svmnotn commented Dec 12, 2017

If we run cargo uninstall followed by an install from the git repo the issue is solved. This is how I've been temporarily fixing it, thus only using cargo update to tell me the version changed.
As in:

  1. Running cargo install-update, says there is an update to a git package.
  2. Optionally cancel that update as that will save time.
  3. Run cargo uninstall $packge
  4. Run cargo install --git $repo
  5. Re run cargo install-update if you have more git packges to check.

@matthiaskrgr
Copy link
Contributor

Is there a way to

  1. check if the package needs update, if yes
  2. do a release build, if release build succeeds
  3. cargo uninstall the old version
  4. reinstall the new version (without having to rebuild)
    ?

IMO just uninstalling first and then trying to build the latest version is bad because if build fails, we end up with no running version on the system.

@svmnotn
Copy link
Author

svmnotn commented Jan 14, 2018

  1. yes, that is what install-update does to decide whether to do something or not.
  2. should be as simple as doing what they already do
  3. this would depend on install-update keeping track on whether the build went ok or not, but should be doable?
  4. just redo step 2, I guess.
    The issue is that this means git packages that need an update are compiled twice.

@mati865
Copy link
Contributor

mati865 commented May 29, 2018

The fix has made it through and is available from rustc 1.28.0-nightly (5bf68db6e 2018-05-28) onwards.

@nabijaczleweli
Copy link
Owner

Nice! Will close when fix hits stable.

@mati865
Copy link
Contributor

mati865 commented Aug 7, 2018

Rust 1.28 is stable already.

@nabijaczleweli
Copy link
Owner

Thanks for watching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants