Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute name when printing unsuccessful OCSP response status #477

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Jan 19, 2021

This used to throw an AttributeError since the incorrect attribute name was specified. E.g.

➜ python -m sslyze --regular e-saksham.nic.in

 CHECKING HOST(S) AVAILABILITY
 -----------------------------

   e-saksham.nic.in:443                       => 164.100.229.145 




Traceback (most recent call last):
  File "/home/faheel/.asdf/installs/python/3.8.6/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/faheel/.asdf/installs/python/3.8.6/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/__main__.py", line 84, in <module>
    main()
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/__main__.py", line 76, in main
    output_hub.server_scan_completed(scan_result)
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/cli/output_hub.py", line 53, in server_scan_completed
    out_generator.server_scan_completed(server_scan_result)
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/cli/console_output.py", line 75, in server_scan_completed
    for line in cli_connector_cls.result_to_console_output(scan_command_result):
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/plugins/certificate_info/_cli_connector.py", line 92, in result_to_console_output
    result_as_txt.extend(cls._cert_deployment_to_console_output(index, cert_deployment))
  File "/home/faheel/.local/lib/python3.8/site-packages/sslyze/plugins/certificate_info/_cli_connector.py", line 234, in _cert_deployment_to_console_output
    cert_deployment.ocsp_response.status.name
AttributeError: '_OCSPResponse' object has no attribute 'status'

This used to throw an `AttributeError` since the incorrect attribute name was specified
@nabla-c0d3
Copy link
Owner

Thanks

@nabla-c0d3 nabla-c0d3 merged commit f6ec2b3 into nabla-c0d3:release Jan 20, 2021
@nabla-c0d3
Copy link
Owner

Released as v4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants