Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer to GitHub action #7

Open
peter279k opened this issue Dec 17, 2021 · 3 comments
Open

Transfer to GitHub action #7

peter279k opened this issue Dec 17, 2021 · 3 comments

Comments

@peter279k
Copy link

As title, since Travis CI will not be friendly for open source projects, I think it's time to transfer to the GitHub action.

@me-shaon
Copy link
Collaborator

me-shaon commented Dec 18, 2021

@nahid I've added github workflow for this package, but the tests will fail due to old dependencies. The issue is not with the workflow but the package dependencies. Please check the workflow logs.
https://github.com/nahid/qarray/actions/runs/1595262009

You need to decide whether you should support old versions. Otherwise it'd be hard to fix the tests.

@nahid
Copy link
Owner

nahid commented Dec 18, 2021

@me-shaon it'll be complicated if we support the legacy PHP versions. So I think we should remove old PHP versions support from this package and PHP 7.1 should be minimum version.

@peter279k
Copy link
Author

peter279k commented Dec 18, 2021

It's related to issue #6.

I think there're two approaches to fix installing dependencies issue:

  • In order to support lower PHP versions, using the "myclabs/deep-copy": "^1.7", on Composer.json.
  • In order to support PHP 7.1 version at least, using the "myclabs/deep-copy": "^1.8", on Composer.json. And it should let this package require php-7.1 version at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants