Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality?: Add additional check to StonksFabricHelper.instantOffer() #26

Closed
nahkd123 opened this issue Aug 13, 2023 · 0 comments · Fixed by #27
Closed

Quality?: Add additional check to StonksFabricHelper.instantOffer() #26

nahkd123 opened this issue Aug 13, 2023 · 0 comments · Fixed by #27
Labels
enhancement New feature or request

Comments

@nahkd123
Copy link
Owner

oh thanks god I don't have make another hotfix just to fix potential dupe glitch.

There's an ongoing dupe glitch where attacker can consume item while the screen is opened ("screen" as in container GUI). Basically you open the screen, consume the item without exiting the screen, and then click on "confirm button" to get the item listed.

Fortunately, StonksFabricHelper.placeOffer() (or something like that) already have another check to confirm that you have at least X items in inventory or $X in your account. The only thing I need to add is another check in instantOffer(), which is actually handled at menu level in instant buy menus (quick buy + confirm buy menus).

@nahkd123 nahkd123 added the enhancement New feature or request label Aug 13, 2023
@nahkd123 nahkd123 added this to the Maintenance Release 2.0.2 milestone Aug 13, 2023
@nahkd123 nahkd123 added breaking Breaking changes. Should only be applied on major version. and removed breaking Breaking changes. Should only be applied on major version. labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant