You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
oh thanks god I don't have make another hotfix just to fix potential dupe glitch.
There's an ongoing dupe glitch where attacker can consume item while the screen is opened ("screen" as in container GUI). Basically you open the screen, consume the item without exiting the screen, and then click on "confirm button" to get the item listed.
Fortunately, StonksFabricHelper.placeOffer() (or something like that) already have another check to confirm that you have at least X items in inventory or $X in your account. The only thing I need to add is another check in instantOffer(), which is actually handled at menu level in instant buy menus (quick buy + confirm buy menus).
The text was updated successfully, but these errors were encountered:
nahkd123
added
breaking
Breaking changes. Should only be applied on major version.
and removed
breaking
Breaking changes. Should only be applied on major version.
labels
Aug 14, 2023
oh thanks god I don't have make another hotfix just to fix potential dupe glitch.
There's an ongoing dupe glitch where attacker can consume item while the screen is opened ("screen" as in container GUI). Basically you open the screen, consume the item without exiting the screen, and then click on "confirm button" to get the item listed.
Fortunately,
StonksFabricHelper.placeOffer()
(or something like that) already have another check to confirm that you have at least X items in inventory or $X in your account. The only thing I need to add is another check ininstantOffer()
, which is actually handled at menu level in instant buy menus (quick buy + confirm buy menus).The text was updated successfully, but these errors were encountered: