-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP2 option #29
Comments
Hi @nakabonne I would like to work on this. The changes would be as simple as opts.Attacker = vegeta.NewAttacker(
vegeta.Timeout(opts.Timeout),
vegeta.Workers(opts.Workers),
vegeta.MaxWorkers(opts.MaxWorkers),
vegeta.MaxBody(opts.MaxBody),
vegeta.KeepAlive(opts.KeepAlive),
vegeta.HTTP2(true),
) in the below file. Right? Or do we need to identify somehow whether the server supports HTTP2? Just wanted to make sure I understand the changes required before raising a PR. Line 75 in fb9a839
|
Exactly. All we have to do is just pass the value received from the flag to vegeta. Look forward to your PR! |
@nakabonne I have raised a PR for the same #49 |
Closing since this was resolved by #49 |
Only tiny changes are required because all we have to do is just pass to the Vegeta API.
The text was updated successfully, but these errors were encountered: