You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your work on this project, it has been working great for us.
There's a small thing about the handling of the nb_workers argument of pandarallel.initialize I'd like to suggest.
Currently the default value is generated at the top of the file as a global, then set as the default argument of the function. This means if my program has an n_cpus-type Optional argument, I can't just set this as the nb_workers argument as this would overwrite the default value and break things.
thanks for your interest in this package and your willingness to contribute. Sorry for the delay.
I don't think I am following your intended behaviour exactly. Could you describe again what you'd like to do that doesn't work using the current setup?
Irrespective of that, I think it there's an argument to be made that the behaviour of nb_workers and use_memory_fs should be the same.
Thanks for your work on this project, it has been working great for us.
There's a small thing about the handling of the
nb_workers
argument ofpandarallel.initialize
I'd like to suggest.Currently the default value is generated at the top of the file as a global, then set as the default argument of the function. This means if my program has an
n_cpus
-type Optional argument, I can't just set this as thenb_workers
argument as this would overwrite the default value and break things.Ideally it would be
This would also match the argument handling of
use_memory_fs
.I can raise a PR for this if there's interest
The text was updated successfully, but these errors were encountered: