Question about Coordinators

[Reak45]

Hello again :)
Another question. Have you tried pushing UIHostingController from UINavigationController? I encountered a weird issue following your implementation. I have a root UIHostingController embedded in UINavigationController. When I am pushing new UIHostingController with title and navigation bar item using standard pushViewController method, the title and the item do not appear smoothly when navigating / animating. Rather they are "jumping in" when the view finishes navigation. Have you encountered anything like that?

[nalexn]

I haven't encountered this, but here are a few ideas to try as the fix.

Here:

After some debugging I realized that the UIHostingController itself calls setNavigationBarHidden again.
So the reason for this problem is, that the UIHostingControllers alters the surrounding UINavigationController's UINavigationBar.

In order to prevent UIHostingControllers from messing with the navigation bar, you can try:

1. Disabling navigation bar from the SwiftUI side
2. Embed the UIHostingController in a normal UIViewController as a child view controller, and safely configure the navigation bar for the UIViewController

[Reak45]

Thank you. I'll look into it

[Reak45]

Hello again! I have one more question regarding your coordinator implementation. I just love it! But I encountered a small problem. In a part of my app I need to present "modally" a view controller and get some selection data from the user back to the presenting view controller. What would be the best way to return the data back to the presenting view controller? I tried many different approaches but none of them was satisfying enough. Could you please advice?

[nalexn]

Hey! I can think of two approaches, first is a traditional reactive coordinator, where you add a generic parameter to BaseCoordinator<Value> and make the function func start() -> AnyPublisher<Value, Never> return the result.
The idea is that you now can supply the result when the Details screen finishes its work and listen to the value in the parent coordinator. I've been using this approach with RxSwift, but this idea can be translated to Combine as well. You can read more in the section Coordinators in this post.
The second approach is to simply add a Closure callback to the Details Coordinator and call it with the result when your screen is done, and assign the closure value in the parent coordinator

[Reak45]

Let's consider a small piece of HomeViewCoordinator. In start method you have something like this:
viewModel.onSelect.sink { [weak self] transaction in self?.showDetails(transaction: transaction) }. It is responsible for showing the details of the selected transaction. Let's say that on transaction details screen there is something to select. When the user selects something there, some method from HomeViewModel should be invoked.
So, in first approach I need to refactor showDetails so its return AnyPublisher? And then sink and call the appropriate method from HomeViewModel?
In the second approach I should pass callback as a second parameter?