-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onItemSelect only fires once per page refresh #51
Comments
Very strange. This does not seem to be the case with the demo. Can you demonstrate the bug? |
Same problem here. Works only once per page refresh. Has this been resolved in some way? |
Has anyone managed to fix this yet? I have the same problem and I can't find a solution. |
I figured a solution, but don't know why. If you install: {
test: /\.js$/,
loader: 'babel-loader',
exclude: /node_modules/,
query: {
presets: ['react', 'es2015'],
plugins: ['transform-class-properties']
}
} it runs correctly. Edit: this is due to the arrow notation that is being used. |
@jlubben thank you for finding this! :) We do use class properties in the code for this module, mainly the bound functions like this: class Timeline extends Component {
boundFunction = () => {
return this.instanceProperty;
}
} When the library is built, all of the code is converted (transpiled) to regular ES5 via babel and can be imported anywhere without complications. However if you use a build tool that supports If then your babel configuration is not set up like the library's, you may run into problems. I personally use these presets:
Adding I added a note for this into the README Closing the issue now. Feel free to reopen in case of problems! |
When you select an item, then select another item, then select the original item. The original item will ignore the click event
The text was updated successfully, but these errors were encountered: