Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule event needs to be fixed #739

Closed
honggyukim opened this issue May 2, 2019 · 4 comments
Closed

schedule event needs to be fixed #739

honggyukim opened this issue May 2, 2019 · 4 comments
Labels

Comments

@honggyukim
Copy link
Collaborator

I think current linux:schedule event is not mature and it has the following problems as of now.

  • It doesn't work well with record time time-filter
    • So when distributing the recorded data, always have to mention to use time-filter for analysis.
    • otherwise, the output screen is covered by too many noisy scheduling events as mentioned in "inverted time" #699 (comment).
  • --no-event simply hides this scheduling events, but it also disables task-name event as well.
    • The only way to work around this is to use --no-event -E linux:task-name, but it doesn't look nice.

In most cases, I'm only interested in task-name and not interested in scheduling event.
I would like to suggest the following choices.

  1. --no-sched option to disable only schedule event.
  2. disable schedule event by default and add --sched option to turn it on.
  3. schedule event doesn't work with time-filter #658 (comment) can be a solution
@honggyukim
Copy link
Collaborator Author

As we discussed today, I think we better provide a way to apply default options from a pre-defined opt file that is inside of uftrace.data.

We can generate the opt file inside uftrace.data to apply the time-filter used by record command. This can be the simplest fix as wrote in "3" above.

@honggyukim
Copy link
Collaborator Author

Otherwise, It would be also good to always use -E linux:task-name even if --no-event is used.

@honggyukim
Copy link
Collaborator Author

Otherwise, It would be also good to always use -E linux:task-name even if --no-event is used.

@namhyung What about applying this as well? Is there any benefit of not recording linux:task-name?

@namhyung
Copy link
Owner

Well, it doesn't honor the meaning of NO events and maybe sometimes users want to remove overhead of perf events at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants