Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match version of the chrome by default #2

Closed
krasnoukhov opened this issue Jan 3, 2020 · 0 comments · Fixed by #3
Closed

Match version of the chrome by default #2

krasnoukhov opened this issue Jan 3, 2020 · 0 comments · Fixed by #3

Comments

@krasnoukhov
Copy link
Contributor

I'd like to use this action but hardcoding the version does not sound like a scalable option. Would it make sense to auto-determine the version by default?

CHROME_VERSION=$(google-chrome --version | cut -f 3 -d ' ' | cut -d '.' -f 1)
CHROME_DRIVER_VERSION=$(curl --location --fail --retry 3 http://chromedriver.storage.googleapis.com/LATEST_RELEASE_${CHROME_VERSION})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match chrome version by default simplepractice/setup-chromedriver
1 participant
@krasnoukhov