Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect callback url #9

Open
nandito opened this issue Sep 2, 2017 · 0 comments
Open

Fix redirect callback url #9

nandito opened this issue Sep 2, 2017 · 0 comments
Labels

Comments

@nandito
Copy link
Owner

nandito commented Sep 2, 2017

The log in fails if user logs out on the coffees page, then tries to log in.

This happens because the redirect from the App.js

<Redirect to={{
  pathname: '/',
  state: { from: props.location },
}}/>

sets the from prop to show the nice unauthorized message on the homepage.

And this from: {pathname: "/coffees", search: "", hash: "", state: undefined, key: "..."} is being used for the redirect - and fails because /coffees is not the proper callback url.

Ideas:

  • clear the from from the history when logging in
  • do not set from, try using other name maybe, etc.
@nandito nandito added the bug label Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant