Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link / push change URL+ execute getServerSideProps, but "setParams" (createParam) change URL but no getServerSideProps #473

Open
2 of 3 tasks
tompap opened this issue May 10, 2024 · 2 comments

Comments

@tompap
Copy link

tompap commented May 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Do you want this issue prioritized?

  • Yes, I have sponsored
  • Not urgent

Current Behavior

When updating screen params using setParams of createParam I was excepting that next will executed getServerSideProps but this is not the case.
When using Link or useRouter (push) getServiceSideProps is executed

Example
A button : link href="/?page=2" => getServerSideProps is executed
A button: Pressable onPress => setParams({page:2}) => getServerSideProps is not executed

Expected Behavior

Behavior should be the same

Steps To Reproduce

No response

Versions

- Solito: 4.0.1
- Next.js: 13
- Expo: 50

Screenshots

No response

Reproduction

No response

@tompap
Copy link
Author

tompap commented May 14, 2024

Ok I found that { shallow: true} is hardcoded in the setparams, should it be configurable ?

@nandorojo
Copy link
Owner

Interesting…suppose this could be configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants