Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Trailer Video Format not persisting across container instances #40

Closed
Andrewpaps opened this issue Sep 19, 2024 · 3 comments · Fixed by #42
Closed

[Bug] Trailer Video Format not persisting across container instances #40

Andrewpaps opened this issue Sep 19, 2024 · 3 comments · Fixed by #42
Labels
bug Something isn't working

Comments

@Andrewpaps
Copy link

Describe the bug
When selecting Trailer Video format other than default (h264) to something else (eg. av1), settings do not seem to persist across container restarts.

Not sure if I need to specify the GPU as a variable in the container perhaps.

May also occur with other settings, not sure.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings
  2. Change Trailer Video Format from h264
  3. Restart container

Actual behavior
Setting reverts to default.

Expected behavior
Settings are saved between container instances.

@Andrewpaps Andrewpaps added the bug Something isn't working label Sep 19, 2024
@nandyalu
Copy link
Owner

Trailarr saves it's app data including settings and database in /data by default which can be changed by modifying APP_DATA_DIR env variable, and map that folder to a local folder for persisting the data.

I know you had issues with your config from issue #38. Can you open /mnt/cache/appdata/trailarr in your system and check if there is a .env file in there and post the contents of that file?

@nandyalu nandyalu added help wanted Extra attention is needed and removed bug Something isn't working labels Sep 19, 2024
@Andrewpaps
Copy link
Author

Sure. There is a .env file.

The contents before restart are:

API_KEY='c21d21be5091648d1cd6e9e9dd15824b'
DEBUG='False'
TESTING='False'
DATABASE_URL='sqlite:////config/trailarr.db'
MONITOR_ENABLED='True'
MONITOR_INTERVAL='60'
WAIT_FOR_MEDIA='True'
TRAILER_FOLDER_MOVIE='True'
TRAILER_FOLDER_SERIES='True'
TRAILER_RESOLUTION='2160'
TRAILER_AUDIO_FORMAT='aac'
TRAILER_VIDEO_FORMAT='av1'
TRAILER_SUBTITLES_ENABLED='True'
TRAILER_SUBTITLES_LANGUAGE='en'
TRAILER_FILE_FORMAT='mkv'
TRAILER_EMBED_METADATA='True'
TRAILER_REMOVE_SPONSORBLOCKS='True'
TRAILER_WEB_OPTIMIZED='True'

And after:

API_KEY='c21d21be5091648d1cd6e9e9dd15824b'
DEBUG='False'
TESTING='False'
DATABASE_URL='sqlite:////config/trailarr.db'
MONITOR_ENABLED='True'
MONITOR_INTERVAL='60'
WAIT_FOR_MEDIA='True'
TRAILER_FOLDER_MOVIE='True'
TRAILER_FOLDER_SERIES='True'
TRAILER_RESOLUTION='2160'
TRAILER_AUDIO_FORMAT='aac'
TRAILER_VIDEO_FORMAT='srt'
TRAILER_SUBTITLES_ENABLED='True'
TRAILER_SUBTITLES_LANGUAGE='en'
TRAILER_FILE_FORMAT='mkv'
TRAILER_EMBED_METADATA='True'
TRAILER_REMOVE_SPONSORBLOCKS='True'
TRAILER_WEB_OPTIMIZED='True'

Some of these settings are persisting no problem. Just "TRAILER_VIDEO_FORMAT" looks to be getting removed.

@nandyalu
Copy link
Owner

nandyalu commented Sep 19, 2024

There is a bug in code that is saving trailer_subtitle_format to TRAILER_VIDEO_FORMAT. Will fix this, to make it work for now, just update the Trailer Video Format option and it should override it.

@nandyalu nandyalu added bug Something isn't working and removed help wanted Extra attention is needed labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants