Skip to content

Commit ddd69d0

Browse files
authored
Fix warnings for all fields required/used in the native end (#19)
1 parent 8deae82 commit ddd69d0

File tree

12 files changed

+37
-0
lines changed

12 files changed

+37
-0
lines changed

source/System/AppDomain.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,13 @@ namespace System
1515
/// </summary>
1616
public sealed class AppDomain : MarshalByRefObject
1717
{
18+
// these fields are required in the native end
19+
#pragma warning disable 0649, 0169
1820
[FieldNoReflection]
1921
private object _appDomain;
2022
private string _friendlyName;
23+
#pragma warning restore 0649
24+
#pragma warning restore 0169
2125

2226
private AppDomain()
2327
{

source/System/Boolean.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ public struct Boolean
2121
/// </summary>
2222
public static readonly string TrueString = "True";
2323

24+
// this field is required in the native end
25+
#pragma warning disable 0649
2426
private bool _value;
27+
#pragma warning restore 0649
2528

2629
/// <summary>
2730
/// Converts the value of this instance to its equivalent string representation (either "True" or "False").

source/System/Byte.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ namespace System
1414
[Serializable]
1515
public struct Byte
1616
{
17+
// this field is required in the native end
18+
#pragma warning disable 0649
1719
private byte _value;
20+
#pragma warning restore 0649
1821

1922
/// <summary>
2023
/// Represents the largest possible value of a Byte. This field is constant.

source/System/Char.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ namespace System
1212
[Serializable]
1313
public struct Char
1414
{
15+
// this field is required in the native end
16+
#pragma warning disable 0649
1517
private char _value;
18+
#pragma warning restore 0649
1619

1720
/// <summary>
1821
/// Represents the largest possible value of a Char. This field is constant.

source/System/Double.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@ namespace System
1515
[Serializable]
1616
public struct Double
1717
{
18+
// this field is required in the native end
19+
#pragma warning disable 0649
1820
internal double _value;
21+
#pragma warning restore 0649
1922

2023
/// <summary>
2124
/// Represents the smallest possible value of a Double. This field is constant.

source/System/Exception.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ public class Exception
1717
private readonly string _message;
1818
private readonly Exception _innerException;
1919

20+
// this field is required in the native end
21+
#pragma warning disable 0169
2022
private object _stackTrace;
23+
#pragma warning restore 0169
2124

2225
/// <summary>
2326
/// Gets or sets HRESULT, a coded numerical value that is assigned to a specific exception.

source/System/Int16.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ namespace System
1414
[Serializable]
1515
public struct Int16
1616
{
17+
// this field is required in the native end
18+
#pragma warning disable 0649
1719
internal short _value;
20+
#pragma warning restore 0649
1821

1922
/// <summary>
2023
/// Represents the largest possible value of an Int16. This field is constant.

source/System/SByte.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ namespace System
1414
[Serializable, CLSCompliant(false)]
1515
public struct SByte
1616
{
17+
// this field is required in the native end
18+
#pragma warning disable 0649
1719
private sbyte _value;
20+
#pragma warning restore 0649
1821

1922
/// <summary>
2023
/// Represents the largest possible value of SByte. This field is constant.

source/System/Threading/Thread.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@ namespace System.Threading
1414
/// </summary>
1515
public sealed class Thread
1616
{
17+
// these fields are required in the native end
18+
#pragma warning disable 0169
1719
private Delegate _delegate;
1820
private int _priority;
1921
[Reflection.FieldNoReflection]
2022
private object _thread;
2123
[Reflection.FieldNoReflection]
2224
private object _appDomain;
2325
private int _id;
26+
#pragma warning restore 0169
2427

2528
/// <summary>
2629
/// Initializes a new instance of the Thread class.

source/System/Threading/Timer.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@ namespace System.Threading
2020
/// </summary>
2121
public sealed class Timer : MarshalByRefObject, IDisposable
2222
{
23+
// these fields are required in the native end
24+
#pragma warning disable 0169
2325
[Reflection.FieldNoReflection]
2426
private object _timer;
2527
private object _state;
2628
private TimerCallback _callback;
29+
#pragma warning restore 0169
2730

2831
/// <summary>
2932
/// Initializes a new instance of the Timer class, using a 32-bit signed integer to specify the time interval.

0 commit comments

Comments
 (0)