Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new TimeSpan.From methods #57

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Add new TimeSpan.From methods #57

merged 2 commits into from
Nov 28, 2018

Conversation

gligorov
Copy link
Contributor

@gligorov gligorov commented Nov 25, 2018 •
edited by josesimoes
Loading

Description

  • Added methods to create timespan from miliseconds/Seconds/Minutes/Hours/Days .

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 25, 2018

Hi @gligorov,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gligorov gligorov changed the title Added the missing FromMiliseconds Method Added the missing FromMiliseconds/Seconds/Minutes/Hours/Days Methods Nov 25, 2018
@josesimoes josesimoes changed the title Added the missing FromMiliseconds/Seconds/Minutes/Hours/Days Methods Add new TimeSpan.From methods Nov 26, 2018
josesimoes
josesimoes approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit a160f28 into nanoframework:develop Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gligorov @nfbot @CLAassistant @josesimoes