Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes throughout the code base #74

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add pragma disables to explicitly declare intention.

Motivation and Context

  • Addressing SonarCloud analysis.
  • Add pragma disables to explicitly declare intention because of nanoFramework requirements and/or constrains and need to use code pattern specific to a base class library (which is the case here). These are flagged in code rules meant to be used in code that is NOT a class library like this one.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Add pragma disables to explicitly declare intention because of nanoFramework requirements and/or constrains and need to use code pattern specific to a base class library (which is the case here).
- Addressing SonarCloud analysis.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jun 11, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

Ignoring SonarCloud quality gate failed because of lacking coverage.

@josesimoes josesimoes merged commit 469af6f into nanoframework:develop Jun 11, 2019
@josesimoes josesimoes deleted the fixes-sonarcloud branch June 11, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants