Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Static field objects are now created on constructor. #72

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Static field objects are now created on constructor.

Motivation and Context

  • Creating the static fields objects on the class constructor prevents issues related with using the class or their fields on other static constructor or reference because of the dependencies and the order things get initialized in the CLR.
  • Fixes Uninitialized lock object leads to NRE. Home#453.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Feb 4, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Feb 4, 2019
- Following nanoframework/Windows.Devices.Gpio#72.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit a12052a into nanoframework:develop Feb 4, 2019
@josesimoes josesimoes deleted the fix-static-objects branch February 4, 2019 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninitialized lock object leads to NRE.
2 participants