Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new methods in StorageFolder and StorageFile #33

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Implement new methods in StorageFolder and StorageFile #33

merged 3 commits into from
Apr 23, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Add support for -
StorageFolder

  • Delete
  • Rename
  • GetFolder

StorageFile

  • Delete
  • Rename

How Has This Been Tested?

With sample code
Sample code to be tidied up and committed.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@AdrianSoundy
Implement new methods
052cd84 
Adde suport for  -
StorageFolder
- Delete
- Rename
- GetFolder
StorageFile
- Delete
- Rename
@nfbot
Copy link
Member

nfbot commented Apr 21, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added the Type: enhancement New feature or request label Apr 22, 2019
josesimoes
josesimoes approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title Implement new methods Implement new methods in StorageFolder and StorageFile Apr 23, 2019
@josesimoes josesimoes merged commit 9200b90 into nanoframework:develop Apr 23, 2019
@AdrianSoundy AdrianSoundy mentioned this pull request Apr 23, 2019
Merged
10 tasks
@AdrianSoundy AdrianSoundy deleted the extra-methods branch April 25, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes