Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pairwiseAlignment() moved to pwalign warning in Biostrings >= 2.72.0 #52

Closed
ecrespoSSF opened this issue Aug 28, 2024 · 3 comments · Fixed by #54
Closed

pairwiseAlignment() moved to pwalign warning in Biostrings >= 2.72.0 #52

ecrespoSSF opened this issue Aug 28, 2024 · 3 comments · Fixed by #54
Assignees
Labels

Comments

@ecrespoSSF
Copy link

I was having issues with pairwise alignments using the crossSetSim() and parSeqSim() examples listed in the vignette https://cran.r-project.org/web/packages/protr/vignettes/protr.html#Similarity_calculation_by_sequence_alignment

It wasn't until I tried twoSeqSim() that I received this error:
<simpleError in .load_package_gracefully("pwalign", "starting with BioC 3.19, ", "calling ", fun, "()"): Could not load package pwalign. Is it installed?

Note that starting with BioC 3.19, calling pairwiseAlignment() requires the pwalign package.
Please install it with:

BiocManager::install("pwalign")>

Installing pwalign has fixed the issue using R version 4.4.1 (2024-06-14) -- "Race for Your Life" on this Platform: x86_64-apple-darwin20

@ecrespoSSF
Copy link
Author

ecrespoSSF commented Aug 29, 2024

This twoSeqSim() function is still a problem
In .call_fun_in_pwalign("pairwiseAlignment", ...) :
pairwiseAlignment() has moved to the pwalign package. Please call pwalign::pairwiseAlignment() to
get rid of this warning.

@nanxstats
Copy link
Owner

Thanks for reporting. It seems the pairwise sequence alignment stuff has been moved from Biostrings to pwalign (Bioconductor/Contributions#3361). I will make a CRAN update soon to fix this issue.

@nanxstats nanxstats self-assigned this Aug 29, 2024
@nanxstats nanxstats changed the title Resolved PWAlign Issue pairwiseAlignment() moved to pwalign warning in Biostrings >= 2.72.0 Aug 30, 2024
@nanxstats
Copy link
Owner

protr 1.7.3 is now on CRAN. You can use install.packages("protr") to try the new version. Use type = "source" if the binary is not built by CRAN yet.

In brief, the new behavior is:

  • If Biostrings is not installed, there should be an error saying Biostrings is required and should be installed from Bioconductor.
  • If you have Bioconductor >= 3.19 and Biostrings >= 2.72.0 without pwalign installed, there should be an explicit error in the results saying pwalign is required and should be installed from Bioconductor.
  • If a lower version of Biostrings is installed (possibily due to using a lower version of R and Bioconductor), then things should work as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants